Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43e943c3 authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller
Browse files

[NETLINK]: Fix missing dst_groups initializations in netlink_broadcast users 



netlink_broadcast users must initialize NETLINK_CB(skb).dst_groups to the
destination group mask for netlink_recvmsg.

Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ad93e266

lib/kobject_uevent.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -93,6 +93,7 @@ static int send_uevent(const char *signal, const char *obj, 
		}

		}

	}

	}





	NETLINK_CB(skb).dst_groups = 1;

	return netlink_broadcast(uevent_sock, skb, 0, 1, gfp_mask);

	return netlink_broadcast(uevent_sock, skb, 0, 1, gfp_mask);

}

}

net/xfrm/xfrm_user.c

+8 −0
Original line number Original line Diff line number Diff line
@@ -1152,6 +1152,8 @@ static int xfrm_notify_sa_flush(struct km_event *c) 




	nlh->nlmsg_len = skb->tail - b;

	nlh->nlmsg_len = skb->tail - b;





	NETLINK_CB(skb).dst_groups = XFRMGRP_SA;



	return netlink_broadcast(xfrm_nl, skb, 0, XFRMGRP_SA, GFP_ATOMIC);

	return netlink_broadcast(xfrm_nl, skb, 0, XFRMGRP_SA, GFP_ATOMIC);





nlmsg_failure:

nlmsg_failure:
@@ -1226,6 +1228,8 @@ static int xfrm_notify_sa(struct xfrm_state *x, struct km_event *c) 




	nlh->nlmsg_len = skb->tail - b;

	nlh->nlmsg_len = skb->tail - b;





	NETLINK_CB(skb).dst_groups = XFRMGRP_SA;



	return netlink_broadcast(xfrm_nl, skb, 0, XFRMGRP_SA, GFP_ATOMIC);

	return netlink_broadcast(xfrm_nl, skb, 0, XFRMGRP_SA, GFP_ATOMIC);





nlmsg_failure:

nlmsg_failure:
@@ -1455,6 +1459,8 @@ static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event * 




	nlh->nlmsg_len = skb->tail - b;

	nlh->nlmsg_len = skb->tail - b;





	NETLINK_CB(skb).dst_groups = XFRMGRP_POLICY;



	return netlink_broadcast(xfrm_nl, skb, 0, XFRMGRP_POLICY, GFP_ATOMIC);

	return netlink_broadcast(xfrm_nl, skb, 0, XFRMGRP_POLICY, GFP_ATOMIC);





nlmsg_failure:

nlmsg_failure:
@@ -1480,6 +1486,8 @@ static int xfrm_notify_policy_flush(struct km_event *c) 




	nlh->nlmsg_len = skb->tail - b;

	nlh->nlmsg_len = skb->tail - b;





	NETLINK_CB(skb).dst_groups = XFRMGRP_POLICY;



	return netlink_broadcast(xfrm_nl, skb, 0, XFRMGRP_POLICY, GFP_ATOMIC);

	return netlink_broadcast(xfrm_nl, skb, 0, XFRMGRP_POLICY, GFP_ATOMIC);





nlmsg_failure:

nlmsg_failure:

security/selinux/netlink.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -80,6 +80,7 @@ static void selnl_notify(int msgtype, void *data) 
	nlh = NLMSG_PUT(skb, 0, 0, msgtype, len);

	nlh = NLMSG_PUT(skb, 0, 0, msgtype, len);

	selnl_add_payload(nlh, len, msgtype, data);

	selnl_add_payload(nlh, len, msgtype, data);

	nlh->nlmsg_len = skb->tail - tmp;

	nlh->nlmsg_len = skb->tail - tmp;

	NETLINK_CB(skb).dst_groups = SELNL_GRP_AVC;

	netlink_broadcast(selnl, skb, 0, SELNL_GRP_AVC, GFP_USER);

	netlink_broadcast(selnl, skb, 0, SELNL_GRP_AVC, GFP_USER);

out:

out:

	return;

	return;