Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43df2a57 authored by Thomas Meyer's avatar Thomas Meyer Committed by Takashi Iwai
Browse files

ALSA: usb-audio: Use kmemdup rather than duplicating its implementation 



Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 2f451d2a

sound/usb/quirks.c

+3 −4
Original line number Diff line number Diff line
@@ -137,12 +137,12 @@ static int create_fixed_stream_quirk(struct snd_usb_audio *chip, 
		return -ENOMEM;

	}

	if (fp->nr_rates > 0) {

		rate_table = kmalloc(sizeof(int) * fp->nr_rates, GFP_KERNEL);

		rate_table = kmemdup(fp->rate_table,

				     sizeof(int) * fp->nr_rates, GFP_KERNEL);

		if (!rate_table) {

			kfree(fp);

			return -ENOMEM;

		}

		memcpy(rate_table, fp->rate_table, sizeof(int) * fp->nr_rates);

		fp->rate_table = rate_table;

	}
@@ -224,10 +224,9 @@ static int create_uaxx_quirk(struct snd_usb_audio *chip, 
	if (altsd->bNumEndpoints != 1)

		return -ENXIO;



	fp = kmalloc(sizeof(*fp), GFP_KERNEL);

	fp = kmemdup(&ua_format, sizeof(*fp), GFP_KERNEL);

	if (!fp)

		return -ENOMEM;

	memcpy(fp, &ua_format, sizeof(*fp));



	fp->iface = altsd->bInterfaceNumber;

	fp->endpoint = get_endpoint(alts, 0)->bEndpointAddress;