Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43db70a5 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: pcmad: use comedi_range_is_bipolar() 



Use the core provided helper function instead of duplicating it as
a private function.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b59f105c

drivers/staging/comedi/drivers/pcmad.c

+1 −7
Original line number Original line Diff line number Diff line
@@ -75,12 +75,6 @@ static int pcmad_ai_wait_for_eoc(struct comedi_device *dev, 
	return -ETIME;

	return -ETIME;

}

}





static bool pcmad_range_is_bipolar(struct comedi_subdevice *s,

				   unsigned int range)

{

	return s->range_table->range[range].min < 0;

}



static int pcmad_ai_insn_read(struct comedi_device *dev,

static int pcmad_ai_insn_read(struct comedi_device *dev,

			      struct comedi_subdevice *s,

			      struct comedi_subdevice *s,

			      struct comedi_insn *insn,

			      struct comedi_insn *insn,
@@ -106,7 +100,7 @@ static int pcmad_ai_insn_read(struct comedi_device *dev, 
		if (s->maxdata == 0x0fff)

		if (s->maxdata == 0x0fff)

			val >>= 4;

			val >>= 4;





		if (pcmad_range_is_bipolar(s, range)) {

		if (comedi_range_is_bipolar(s, range)) {

			/* munge the two's complement value */

			/* munge the two's complement value */

			val ^= ((s->maxdata + 1) >> 1);

			val ^= ((s->maxdata + 1) >> 1);

		}

		}