Commit 439a903a authored Oct 19, 2007 by Alan Stern Committed by Greg Kroah-Hartman Oct 25, 2007

USB: fix interface sysfs file-creation bug



This patch (as1005) fixes a rather subtle problem.  When
usb_set_configuration() registers the interfaces and their files in
sysfs, it doesn't expect those files to exist already.  But when an
interface is registered, its driver may call usb_set_interface() and
thereby cause the sysfs files to be created.  The result is an error
when usb_set_configuration() goes on to create those same files again.

The (not-so-great) solution is to have usb_set_configuration() remove
any existing files before creating them.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent b22817b3

drivers/usb/core/message.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -1641,6 +1641,12 @@ free_interfaces:
		intf->dev.bus_id, ret);
		continue;
		}

		/* The driver's probe method can call usb_set_interface(),
		* which would mean the interface's sysfs files are already
		* created. Just in case, we'll remove them first.
		*/
		usb_remove_sysfs_intf_files(intf);
		usb_create_sysfs_intf_files(intf);
		}