Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4386d3ff authored by Veerabhadrarao Badiganti's avatar Veerabhadrarao Badiganti Committed by Gerrit - the friendly Code Review server
Browse files

mmc: sdhci-msm: Don't turnoff Vcc during initialization 



As per emmc specification, device should be notified either with
power-off or sleep notification before turning off the Vcc.
Failing to do so might affect the device longevity.

In mmc driver initialization phase even before device probing
gets completed, Vcc is getting turned off without these notifications.
Since it can't send commands at this stage, So just ensure that Vcc
is not turned off till initialization gets completed.

Change-Id: I0bbf0077357d66c888147be40a0c5d312b9ce063
Signed-off-by: default avatarVeerabhadrarao Badiganti <vbadigan@codeaurora.org>
parent f67a2861

drivers/mmc/host/sdhci-msm.c

+6 −17
Original line number Diff line number Diff line
@@ -2184,21 +2184,6 @@ out: 
	return ret;

}



/*

 * Reset vreg by ensuring it is off during probe. A call

 * to enable vreg is needed to balance disable vreg

 */

static int sdhci_msm_vreg_reset(struct sdhci_msm_pltfm_data *pdata)

{

	int ret;



	ret = sdhci_msm_setup_vreg(pdata, 1, true);

	if (ret)

		return ret;

	ret = sdhci_msm_setup_vreg(pdata, 0, true);

	return ret;

}



/* This init function should be called only once for each SDHC slot */

static int sdhci_msm_vreg_init(struct device *dev,

				struct sdhci_msm_pltfm_data *pdata,
@@ -2233,7 +2218,7 @@ static int sdhci_msm_vreg_init(struct device *dev, 
		if (ret)

			goto vdd_reg_deinit;

	}

	ret = sdhci_msm_vreg_reset(pdata);



	if (ret)

		dev_err(dev, "vreg reset failed (%d)\n", ret);

	goto out;
@@ -2399,7 +2384,9 @@ static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data) 
		io_level = REQ_IO_HIGH;

	}

	if (irq_status & CORE_PWRCTL_BUS_OFF) {

		ret = sdhci_msm_setup_vreg(msm_host->pdata, false, false);

		if (msm_host->pltfm_init_done)

			ret = sdhci_msm_setup_vreg(msm_host->pdata,

					false, false);

		if (!ret) {

			ret = sdhci_msm_setup_pins(msm_host->pdata, false);

			ret |= sdhci_msm_set_vdd_io_vol(msm_host->pdata,
@@ -4365,6 +4352,8 @@ static int sdhci_msm_probe(struct platform_device *pdev) 
		goto free_cd_gpio;

	}



	msm_host->pltfm_init_done = true;



	pm_runtime_set_active(&pdev->dev);

	pm_runtime_enable(&pdev->dev);

	pm_runtime_set_autosuspend_delay(&pdev->dev, MSM_AUTOSUSPEND_DELAY_MS);

drivers/mmc/host/sdhci-msm.h

+1 −0
Original line number Diff line number Diff line
@@ -214,6 +214,7 @@ struct sdhci_msm_host { 
	struct sdhci_msm_pm_qos_irq pm_qos_irq;

	bool tuning_in_progress;

	bool core_3_0v_support;

	bool pltfm_init_done;

};



extern char *saved_command_line;