Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43519e60 authored by Varka Bhadram's avatar Varka Bhadram Committed by David S. Miller
Browse files

ethernet: amd: move amd111e_remove_one after probe 



This patch moves the remove functionalities after the probe
so that we can see the registered and released resources properly.
Every driver follows the same concept.

Signed-off-by: default avatarVarka Bhadram <varkab@cdac.in>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 30c9e022

drivers/net/ethernet/amd/amd8111e.c

+13 −12
Original line number Diff line number Diff line
@@ -1701,18 +1701,6 @@ static int amd8111e_resume(struct pci_dev *pci_dev) 
	return 0;

}





static void amd8111e_remove_one(struct pci_dev *pdev)

{

	struct net_device *dev = pci_get_drvdata(pdev);

	if (dev) {

		unregister_netdev(dev);

		iounmap(((struct amd8111e_priv *)netdev_priv(dev))->mmio);

		free_netdev(dev);

		pci_release_regions(pdev);

		pci_disable_device(pdev);

	}

}

static void amd8111e_config_ipg(struct net_device* dev)

{

	struct amd8111e_priv *lp = netdev_priv(dev);
@@ -1970,6 +1958,19 @@ err_disable_pdev: 


}



static void amd8111e_remove_one(struct pci_dev *pdev)

{

	struct net_device *dev = pci_get_drvdata(pdev);



	if (dev) {

		unregister_netdev(dev);

		iounmap(((struct amd8111e_priv *)netdev_priv(dev))->mmio);

		free_netdev(dev);

		pci_release_regions(pdev);

		pci_disable_device(pdev);

	}

}



static struct pci_driver amd8111e_driver = {

	.name   	= MODULE_NAME,

	.id_table	= amd8111e_pci_tbl,