Commit 43260cf0 authored Jun 01, 2017 by Jaegeuk Kim Committed by Jaegeuk Kim Jul 31, 2017

f2fs: remove false-positive bug_on



commit d8c4256c17dac3e9ec0c441b81292d5d2044c89f upstream.

For example,

f2fs_create
 - new_node_page is failed
 - handle_failed_inode
  - skip to add it into orphan list, since ni.blk_addr == NULL_ADDR
   : set_inode_flag(inode, FI_FREE_NID)

f2fs_evict_inode
 - EIO due to fault injection
 - f2fs_bug_on() is triggered

So, we don't need to call f2fs_bug_on in this case.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent f5451c29

fs/f2fs/inode.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -425,9 +425,10 @@ no_delete:
		if (is_inode_flag_set(inode, FI_FREE_NID)) {
		alloc_nid_failed(sbi, inode->i_ino);
		clear_inode_flag(inode, FI_FREE_NID);
		}
		} else {
		f2fs_bug_on(sbi, err &&
		!exist_written_data(sbi, inode->i_ino, ORPHAN_INO));
		}
		out_clear:
		fscrypt_put_encryption_info(inode, NULL);
		clear_inode(inode);