Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41c57a87 authored by David Barksdale's avatar David Barksdale Committed by Linus Torvalds
Browse files

[PATCH] IPMI: fix timeout list handling 



Fix a dangling pointer bug in ipmi_timeout_handler.  A list of timedout
messages is not re-initialized before reuse, causing the head of the list
to point to freed memory.

Signed-off-by: default avatarDavid Barksdale <amatus@ocgnet.org>
Signed-off-by: default avatarCorey Minyard <minyard@acm.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent fa8609da

drivers/char/ipmi/ipmi_msghandler.c

+1 −2
Original line number Diff line number Diff line
@@ -3649,8 +3649,6 @@ static void ipmi_timeout_handler(long timeout_period) 
	unsigned long        flags;

	int                  i;



	INIT_LIST_HEAD(&timeouts);



	rcu_read_lock();

	list_for_each_entry_rcu(intf, &ipmi_interfaces, link) {

		/* See if any waiting messages need to be processed. */
@@ -3671,6 +3669,7 @@ static void ipmi_timeout_handler(long timeout_period) 
		/* Go through the seq table and find any messages that

		   have timed out, putting them in the timeouts

		   list. */

		INIT_LIST_HEAD(&timeouts);

		spin_lock_irqsave(&intf->seq_lock, flags);

		for (i = 0; i < IPMI_IPMB_NUM_SEQ; i++)

			check_msg_timeout(intf, &(intf->seq_table[i]),