Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 412f3010 authored by Kees Cook's avatar Kees Cook Committed by Jiri Kosina
Browse files

HID: pantherlord: validate output report details 



A HID device could send a malicious output report that would cause the
pantherlord HID driver to write beyond the output report allocation
during initialization, causing a heap overflow:

[  310.939483] usb 1-1: New USB device found, idVendor=0e8f, idProduct=0003
...
[  315.980774] BUG kmalloc-192 (Tainted: G        W   ): Redzone overwritten

CVE-2013-2892

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Cc: stable@kernel.org
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 8c89cc17

drivers/hid/hid-pl.c

+8 −2
Original line number Diff line number Diff line
@@ -132,8 +132,14 @@ static int plff_init(struct hid_device *hid) 
			strong = &report->field[0]->value[2];

			weak = &report->field[0]->value[3];

			debug("detected single-field device");

		} else if (report->maxfield >= 4 && report->field[0]->maxusage == 1 &&

				report->field[0]->usage[0].hid == (HID_UP_LED | 0x43)) {

		} else if (report->field[0]->maxusage == 1 &&

			   report->field[0]->usage[0].hid ==

				(HID_UP_LED | 0x43) &&

			   report->maxfield >= 4 &&

			   report->field[0]->report_count >= 1 &&

			   report->field[1]->report_count >= 1 &&

			   report->field[2]->report_count >= 1 &&

			   report->field[3]->report_count >= 1) {

			report->field[0]->value[0] = 0x00;

			report->field[1]->value[0] = 0x00;

			strong = &report->field[2]->value[0];