Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40ebc0af authored by Sage Weil's avatar Sage Weil Committed by Al Viro
Browse files

ext4: remove unnecessary dentry_unhash on rmdir/rename_dir 



ext4 has no problems with lingering references to unlinked directory
inodes.

CC: "Theodore Ts'o" <tytso@mit.edu>
CC: Andreas Dilger <adilger.kernel@dilger.ca>
CC: linux-ext4@vger.kernel.org
Signed-off-by: default avatarSage Weil <sage@newdream.net>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent f64f58f8

fs/ext4/namei.c

+0 −5
Original line number Diff line number Diff line
@@ -2123,8 +2123,6 @@ static int ext4_rmdir(struct inode *dir, struct dentry *dentry) 
	struct ext4_dir_entry_2 *de;

	handle_t *handle;



	dentry_unhash(dentry);



	/* Initialize quotas before so that eventual writes go in

	 * separate transaction */

	dquot_initialize(dir);
@@ -2352,9 +2350,6 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, 
	struct ext4_dir_entry_2 *old_de, *new_de;

	int retval, force_da_alloc = 0;



	if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))

		dentry_unhash(new_dentry);



	dquot_initialize(old_dir);

	dquot_initialize(new_dir);