Commit 40ba60dd authored Aug 20, 2009 by Jussi Kivilinna Committed by John W. Linville Aug 28, 2009

rndis_wlan: fix broken logic in add_wep_key()



add_wep_key() tries to check if key length is not 5 AND not 13
but uses (key_len != 5 || key_len != 13) instead. Fix this.

Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 84f6a01c

drivers/net/wireless/rndis_wlan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1214,7 +1214,7 @@ static int add_wep_key(struct usbnet usbdev, char key, int key_len, int index)
		struct ndis_80211_wep_key ndis_key;
		int cipher, ret;

		if ((key_len != 5 \|\| key_len != 13) \|\| index < 0 \|\| index > 3)
		if ((key_len != 5 && key_len != 13) \|\| index < 0 \|\| index > 3)
		return -EINVAL;

		if (key_len == 5)