Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40ac7165 authored by Archana Sriram's avatar Archana Sriram Committed by Gerrit - the friendly Code Review server
Browse files

msm: kgsl: Fix reading lm_sequence in _execute_reg_sequence() 



Added proper checks while reading lm_sequence array so that it
is not accessed beyond lm_size.

CRs-Fixed: 2175951
Change-Id: I639b07fba275aad0f62cc03fa11201c126e24812
Signed-off-by: default avatarArchana Sriram <apsrir@codeaurora.org>
parent e8ee04c4

drivers/gpu/msm/adreno_a5xx.c

+8 −12
Original line number Diff line number Diff line
@@ -1265,31 +1265,27 @@ static int _execute_reg_sequence(struct adreno_device *adreno_dev, 


	/* todo double check the reg writes */

	while ((cur - opcode) < length) {

		switch (cur[0]) {

		if (cur[0] == 1 && ((cur + 4) - opcode) <= length) {

			/* Write a 32 bit value to a 64 bit reg */

		case 1:

			reg = cur[2];

			reg = (reg << 32) | cur[1];

			kgsl_regwrite(KGSL_DEVICE(adreno_dev), reg, cur[3]);

			cur += 4;

			break;

		} else if (cur[0] == 2 && ((cur + 5) - opcode) <= length) {

			/* Write a 64 bit value to a 64 bit reg */

		case 2:

			reg = cur[2];

			reg = (reg << 32) | cur[1];

			val = cur[4];

			val = (val << 32) | cur[3];

			kgsl_regwrite(KGSL_DEVICE(adreno_dev), reg, val);

			cur += 5;

			break;

		} else if (cur[0] == 3 && ((cur + 2) - opcode) <= length) {

			/* Delay for X usec */

		case 3:

			udelay(cur[1]);

			cur += 2;

			break;

		default:

		} else

			return -EINVAL;

	} }

	}

	return 0;

}