Commit 40836c48 authored Oct 13, 2008 by Alan Cox Committed by Linus Torvalds Oct 13, 2008

serial_8250: pci_enable_device fail is not fully handled



<rmk> talking about leaks - I noticed that the 'check return of
pci_enable_dev()' in the 8250 pci resume function finally made it in
despite my objections against it (causing stuff in higher levels to
leak).

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 43b11d33

drivers/serial/8250_pci.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2041,9 +2041,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
		* The device may have been disabled. Re-enable it.
		*/
		err = pci_enable_device(dev);
		/* FIXME: We cannot simply error out here */
		if (err)
		return err;

		printk(KERN_ERR "pciserial: Unable to re-enable ports, trying to continue.\n");
		pciserial_resume_ports(priv);
		}
		return 0;