Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4074ea21 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: ice1724 - Fix IRQ register initialization 



The IRQMASK register has to be set to zero expclitily at the initialization
otherwise you'll get no interrupts properly at later operations.

Also, removed the old commented out codes.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9cbbb3ac

sound/pci/ice1712/ice1724.c

+3 −6
Original line number Original line Diff line number Diff line
@@ -2353,7 +2353,6 @@ static int __devinit snd_vt1724_create(struct snd_card *card, 
{

{

	struct snd_ice1712 *ice;

	struct snd_ice1712 *ice;

	int err;

	int err;

	/* unsigned char mask; */

	static struct snd_device_ops ops = {

	static struct snd_device_ops ops = {

		.dev_free =	snd_vt1724_dev_free,

		.dev_free =	snd_vt1724_dev_free,

	};

	};
@@ -2414,11 +2413,9 @@ static int __devinit snd_vt1724_create(struct snd_card *card, 
		return -EIO;

		return -EIO;

	}

	}





	/* unmask used interrupts */

	/* clear interrupts -- otherwise you'll get irq problems later */

#if 0 /* these are enabled/disabled dynamically */

	outb(0, ICEREG1724(ice, IRQMASK));

	mask = VT1724_IRQ_MPU_RX | VT1724_IRQ_MPU_TX;



	outb(mask, ICEREG1724(ice, IRQMASK));

#endif

	/* don't handle FIFO overrun/underruns (just yet),

	/* don't handle FIFO overrun/underruns (just yet),

	 * since they cause machine lockups

	 * since they cause machine lockups

	 */

	 */