Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4035e456 authored by Toby Gray's avatar Toby Gray Committed by Greg Kroah-Hartman
Browse files

USB: cdc-acm: Adding second ACM channel support for various Nokia and one Samsung phones 



S60 phones from Nokia and Samsung expose two ACM channels. The first is a modem
with a standard AT-command interface, which is picked up correctly by CDC-ACM.

The second ACM port is marked as having a vendor-specific protocol. This means
that the ACM driver will not claim the second channel by default.

This adds support for the second ACM channel for the following devices:
    Nokia E63
    Nokia E75
    Nokia 6760 Slide
    Nokia E52
    Nokia E55
    Nokia E72
    Nokia X6
    Nokia N97 Mini
    Nokia 5800 Xpressmusic
    Nokia E90
    Samsung GTi8510 (INNOV8)

Signed-off-by: default avatarToby Gray <toby.gray@realvnc.com>
Cc: Oliver Neukum <oliver@neukum.name>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent caf3a636

drivers/usb/class/cdc-acm.c

+16 −0
Original line number Diff line number Diff line
@@ -1481,6 +1481,11 @@ static int acm_reset_resume(struct usb_interface *intf) 
		USB_CLASS_COMM, USB_CDC_SUBCLASS_ACM, \

		USB_CDC_ACM_PROTO_VENDOR)



#define SAMSUNG_PCSUITE_ACM_INFO(x) \

		USB_DEVICE_AND_INTERFACE_INFO(0x04e7, x, \

		USB_CLASS_COMM, USB_CDC_SUBCLASS_ACM, \

		USB_CDC_ACM_PROTO_VENDOR)



/*

 * USB driver structure.

 */
@@ -1591,6 +1596,17 @@ static const struct usb_device_id acm_ids[] = { 
	{ NOKIA_PCSUITE_ACM_INFO(0x0108), }, /* Nokia 5320 XpressMusic 2G */

	{ NOKIA_PCSUITE_ACM_INFO(0x01f5), }, /* Nokia N97, RM-505 */

	{ NOKIA_PCSUITE_ACM_INFO(0x02e3), }, /* Nokia 5230, RM-588 */

	{ NOKIA_PCSUITE_ACM_INFO(0x0178), }, /* Nokia E63 */

	{ NOKIA_PCSUITE_ACM_INFO(0x010e), }, /* Nokia E75 */

	{ NOKIA_PCSUITE_ACM_INFO(0x02d9), }, /* Nokia 6760 Slide */

	{ NOKIA_PCSUITE_ACM_INFO(0x01d0), }, /* Nokia E52 */

	{ NOKIA_PCSUITE_ACM_INFO(0x0223), }, /* Nokia E72 */

	{ NOKIA_PCSUITE_ACM_INFO(0x0275), }, /* Nokia X6 */

	{ NOKIA_PCSUITE_ACM_INFO(0x026c), }, /* Nokia N97 Mini */

	{ NOKIA_PCSUITE_ACM_INFO(0x0154), }, /* Nokia 5800 XpressMusic */

	{ NOKIA_PCSUITE_ACM_INFO(0x04ce), }, /* Nokia E90 */

	{ NOKIA_PCSUITE_ACM_INFO(0x01d4), }, /* Nokia E55 */

	{ SAMSUNG_PCSUITE_ACM_INFO(0x6651), }, /* Samsung GTi8510 (INNOV8) */



	/* NOTE: non-Nokia COMM/ACM/0xff is likely MSFT RNDIS... NOT a modem! */