Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40052ca0 authored by Stephen Warren's avatar Stephen Warren Committed by Mark Brown
Browse files

regmap: irq: initialize all irqs to wake disabled 



The kerneldoc for irq_set_irq_wake() says:

    Enable/disable power management wakeup mode, which is
    disabled by default.

regmap_irq_set_wake() clears bits to enable wake for an interrupt,
and sets bits to disable wake. Hence, we should set all bits in
wake_buf initially, to mirror the expected disabled state.

Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 685879f4

drivers/base/regmap/regmap-irq.c

+16 −0
Original line number Diff line number Diff line
@@ -322,6 +322,22 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags, 
		}

	}



	/* Wake is disabled by default */

	if (d->wake_buf) {

		for (i = 0; i < chip->num_regs; i++) {

			d->wake_buf[i] = d->mask_buf_def[i];

			reg = chip->wake_base +

				(i * map->reg_stride * d->irq_reg_stride);

			ret = regmap_update_bits(map, reg, d->wake_buf[i],

						 d->wake_buf[i]);

			if (ret != 0) {

				dev_err(map->dev, "Failed to set masks in 0x%x: %d\n",

					reg, ret);

				goto err_alloc;

			}

		}

	}



	if (irq_base)

		d->domain = irq_domain_add_legacy(map->dev->of_node,

						  chip->num_irqs, irq_base, 0,