Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fa8f071 authored by Gidon Studinski's avatar Gidon Studinski
Browse files

msm: ipa: fix static analysis issues 



Fix several static analysis issues in IPA driver.

Change-Id: If04e11b9e44aabb7c9389dbf79ed9c80c66c877e
Signed-off-by: default avatarGidon Studinski <gidons@codeaurora.org>
parent 4d292211

drivers/platform/msm/ipa/ipa_v2/rmnet_ipa.c

+6 −1
Original line number Diff line number Diff line
@@ -611,6 +611,11 @@ static int wwan_add_ul_flt_rule_to_ipa(void) 
	struct ipa_flt_rule_add flt_rule_entry;

	struct ipa_fltr_installed_notif_req_msg_v01 *req;



	if (ipa_qmi_ctx == NULL) {

		IPAWANERR("ipa_qmi_ctx is NULL!\n");

		return -EFAULT;

	}



	pyld_sz = sizeof(struct ipa_ioc_add_flt_rule) +

	   sizeof(struct ipa_flt_rule_add);

	param = kzalloc(pyld_sz, GFP_KERNEL);
@@ -631,7 +636,7 @@ static int wwan_add_ul_flt_rule_to_ipa(void) 
	param->num_rules = (uint8_t)1;



	mutex_lock(&ipa_qmi_lock);

	for (i = 0; i < num_q6_rule && (ipa_qmi_ctx != NULL); i++) {

	for (i = 0; i < num_q6_rule; i++) {

		param->ip = ipa_qmi_ctx->q6_ul_filter_rule[i].ip;

		memset(&flt_rule_entry, 0, sizeof(struct ipa_flt_rule_add));

		flt_rule_entry.at_rear = true;

drivers/platform/msm/ipa/ipa_v3/ipa_dp.c

+1 −1
Original line number Diff line number Diff line
@@ -705,7 +705,7 @@ failure: 
	for (j = 0; j < i; j++) {

		next_pkt = list_next_entry(tx_pkt, link);

		list_del(&tx_pkt->link);

		if (desc[i].type != IPA_DATA_DESC_SKB_PAGED) {

		if (desc[j].type != IPA_DATA_DESC_SKB_PAGED) {

			dma_unmap_single(ipa3_ctx->pdev, tx_pkt->mem.phys_base,

				tx_pkt->mem.size,

				DMA_TO_DEVICE);