Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f56588a authored by Hans de Goede's avatar Hans de Goede Committed by Matthew Garrett
Browse files

dell-laptop: Don't read-back sw_state on machines with a hardware switch 



On machines with a hardware switch, the blocking settings can not be changed
through a Fn + wireless-key combo, so there is no reason to read back the
blocking state from the BIOS.

Reading back is not only not necessary it is actually harmful, since on some
machines the blocking state will be cleared to all 0 after a wireless switch
toggle, even for radios not controlled by the hw-switch (yeah firmware bugs).

This causes "magic" changes to the sw_state. This is inconsistent with other
rfkill drivers which preserve the sw_state over a hw kill on / off.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMatthew Garrett <matthew.garrett@nebula.com>
parent 33f9359a

drivers/platform/x86/dell-laptop.c

+4 −1
Original line number Diff line number Diff line
@@ -428,8 +428,11 @@ out: 
static void dell_rfkill_update_sw_state(struct rfkill *rfkill, int radio,

					int status)

{

	if (!(status & BIT(0))) {

		/* No hw-switch, sync BIOS state to sw_state */

		rfkill_set_sw_state(rfkill, !!(status & BIT(radio + 16)));

	}

}



static void dell_rfkill_update_hw_state(struct rfkill *rfkill, int radio,

					int status)