Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3eda22d1 authored by NeilBrown's avatar NeilBrown Committed by Linus Torvalds
Browse files

[PATCH] md: make 'repair' actually work for raid1 



When 'repair' finds a block that is different one the various parts of the
mirror.  it is meant to write a chosen good version to the others.  However it
currently writes out the original data to each.  The memcpy to make all the
data the same is missing.

Signed-off-by: default avatarNeil Brown <neilb@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 524418bb

drivers/md/raid1.c

+5 −0
Original line number Diff line number Diff line
@@ -1266,6 +1266,11 @@ static void sync_request_write(mddev_t *mddev, r1bio_t *r1_bio) 
					sbio->bi_sector = r1_bio->sector +

						conf->mirrors[i].rdev->data_offset;

					sbio->bi_bdev = conf->mirrors[i].rdev->bdev;

					for (j = 0; j < vcnt ; j++)

						memcpy(page_address(sbio->bi_io_vec[j].bv_page),

						       page_address(pbio->bi_io_vec[j].bv_page),

						       PAGE_SIZE);



				}

			}

	}