Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e9bc58f authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Disable runtime PM when EPSS is unavailable 



According to Mengdong, we shouldn't enable runtime PM when a codec
doesn't support EPSS, based on the experiences on Windows.
We have already this check in HDMI codec drivers, but now apply it in
general in hda_codec.c.

Credit goes to Mengdong Lin <mengdong.lin@intel.com>

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent b1920c21

sound/pci/hda/hda_codec.c

+5 −2
Original line number Diff line number Diff line
@@ -1510,11 +1510,14 @@ int snd_hda_codec_new(struct hda_bus *bus, 
#ifdef CONFIG_PM

	codec->d3_stop_clk = snd_hda_codec_get_supported_ps(codec, fg,

					AC_PWRST_CLKSTOP);

	if (!codec->d3_stop_clk)

		bus->power_keep_link_on = 1;

#endif

	codec->epss = snd_hda_codec_get_supported_ps(codec, fg,

					AC_PWRST_EPSS);

#ifdef CONFIG_PM

	if (!codec->d3_stop_clk || !codec->epss)

		bus->power_keep_link_on = 1;

#endif





	/* power-up all before initialization */

	hda_set_power_state(codec, AC_PWRST_D0);

sound/pci/hda/patch_hdmi.c

+0 −11
Original line number Diff line number Diff line
@@ -1692,17 +1692,6 @@ static int hdmi_parse_codec(struct hda_codec *codec) 
		}

	}



#ifdef CONFIG_PM

	/*

	 * G45/IbexPeak don't support EPSS: the unsolicited pin hot plug event

	 * can be lost and presence sense verb will become inaccurate if the

	 * HDA link is powered off at hot plug or hw initialization time.

	 */

	if (!(snd_hda_param_read(codec, codec->afg, AC_PAR_POWER_STATE) &

	      AC_PWRST_EPSS))

		codec->bus->power_keep_link_on = 1;

#endif



	return 0;

}