Commit 3e9bb2a0 authored Nov 15, 2010 by Vivek Goyal Committed by Jens Axboe Nov 15, 2010

block: fix amiga and atari floppy driver compile warning



Geert, my crosstool don't produce warning below. I guess this has to do
something with compiler version.

- Geert noticed following warning during compilation.

  drivers/block/amiflop.c:1344: warning: ‘rq’ may be used uninitialized in
  this function
  drivers/block/ataflop.c:1402: warning: ‘rq’ may be used uninitialized in
  this function

- Initialize rq to NULL to fix the warning. If we can't find a suitable request
  to dispatch, this function should return NULL instead of a possibly garbage
  pointer.

- Cross compile tested only. Don't have hardware to test it.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>

parent c2f6805d

drivers/block/amiflop.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1341,7 +1341,7 @@ static struct request *set_next_request(void)
		{
		struct request_queue *q;
		int cnt = FD_MAX_UNITS;
		struct request *rq;
		struct request *rq = NULL;

		/* Find next queue we can dispatch from */
		fdc_queue = fdc_queue + 1;

drivers/block/ataflop.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1399,7 +1399,7 @@ static struct request *set_next_request(void)
		{
		struct request_queue *q;
		int old_pos = fdc_queue;
		struct request *rq;
		struct request *rq = NULL;

		do {
		q = unit[fdc_queue].disk->queue;