Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3cf11d77 authored by Gerald Schaefer's avatar Gerald Schaefer Committed by Martin Schwidefsky
Browse files

s390/monwriter: fix smatch warning for strcpy() 



This patch fixes the following smatch warning:
monwrite_diag() error: strcpy() '"LNXAPPL"' too large for 'id.prod_nr'
(8 vs 7)
Using strcpy() is wrong, because it also copies the terminating null
byte, but in this case the extra copied null byte will be overwritten
right after the strcpy(), so there is no real problem here.
Use strncpy() to fix the warning.

Signed-off-by: default avatarGerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 57f47ba0

drivers/s390/char/monwriter.c

+1 −1
Original line number Diff line number Diff line
@@ -60,7 +60,7 @@ static int monwrite_diag(struct monwrite_hdr *myhdr, char *buffer, int fcn) 
	struct appldata_product_id id;

	int rc;



	strcpy(id.prod_nr, "LNXAPPL");

	strncpy(id.prod_nr, "LNXAPPL", 7);

	id.prod_fn = myhdr->applid;

	id.record_nr = myhdr->record_num;

	id.version_nr = myhdr->version;