Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c818ffd authored by Abhishek Kondaveeti's avatar Abhishek Kondaveeti Committed by Shubhraprakash Das
Browse files

msm: isp: Avoid unaligned register access 



Unaligned register access will reslut in device
crash. Avoid them by checking the register address
before accessing them.

Change-Id: Ib58efa2a68115ec9929b9270c123c904737196ee
Signed-off-by: default avatarAbhishek Kondaveeti <akondave@codeaurora.org>
parent 3a214ef8

drivers/media/platform/msm/camera_v2/isp/msm_isp_util.c

+4 −2
Original line number Diff line number Diff line
@@ -1204,7 +1204,8 @@ static int msm_isp_send_hw_cmd(struct vfe_device *vfe_dev, 
			(UINT_MAX - reg_cfg_cmd->u.rw_info.len)) ||

			((reg_cfg_cmd->u.rw_info.reg_offset +

			reg_cfg_cmd->u.rw_info.len) >

			resource_size(vfe_dev->vfe_mem))) {

			resource_size(vfe_dev->vfe_mem)) ||

			(reg_cfg_cmd->u.rw_info.reg_offset & 0x3)) {

			pr_err("%s:%d reg_offset %d len %d res %d\n",

				__func__, __LINE__,

				reg_cfg_cmd->u.rw_info.reg_offset,
@@ -1304,7 +1305,8 @@ static int msm_isp_send_hw_cmd(struct vfe_device *vfe_dev, 
			reg_cfg_cmd->u.mask_info.reg_offset) ||

			(resource_size(vfe_dev->vfe_mem) <

			reg_cfg_cmd->u.mask_info.reg_offset +

			sizeof(temp))) {

			sizeof(temp)) ||

			(reg_cfg_cmd->u.mask_info.reg_offset & 0x3)) {

			pr_err("%s: VFE_CFG_MASK: Invalid length\n", __func__);

			return -EINVAL;

		}