Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c2a6186 authored by Devendra Naga's avatar Devendra Naga Committed by Wim Van Sebroeck
Browse files

Documentation/watchdog: close the fd when cmdline arg given 



in the watchdog test code, the ioctl is performed on the watchdog device
and just doing exit(0) so we leak a filedescripor.

Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 2deca736

Documentation/watchdog/src/watchdog-test.c

+6 −3
Original line number Diff line number Diff line
@@ -47,18 +47,18 @@ int main(int argc, char *argv[]) 
	    ioctl(fd, WDIOC_SETOPTIONS, &flags);

	    fprintf(stderr, "Watchdog card disabled.\n");

	    fflush(stderr);

	    exit(0);

	    goto end;

	} else if (!strncasecmp(argv[1], "-e", 2)) {

	    flags = WDIOS_ENABLECARD;

	    ioctl(fd, WDIOC_SETOPTIONS, &flags);

	    fprintf(stderr, "Watchdog card enabled.\n");

	    fflush(stderr);

	    exit(0);

	    goto end;

	} else {

	    fprintf(stderr, "-d to disable, -e to enable.\n");

	    fprintf(stderr, "run by itself to tick the card.\n");

	    fflush(stderr);

	    exit(0);

	    goto end;

	}

    } else {

	fprintf(stderr, "Watchdog Ticking Away!\n");
@@ -69,4 +69,7 @@ int main(int argc, char *argv[]) 
	keep_alive();

	sleep(1);

    }

end:

    close(fd);

    return 0;

}