Commit 3c1b1ce0 authored Feb 02, 2012 by Julia Lawall Committed by Paul E. McKenney Feb 21, 2012

PTR_ERR should be called before its argument is cleared.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e,e1;
constant c;
@@

*e = c
... when != e = e1
    when != &e
    when != true IS_ERR(e)
*PTR_ERR(e)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reported-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

parent bde23c68

kernel/rcutorture.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1465,12 +1465,15 @@ rcu_torture_onoff(void *arg)
		static int __cpuinit
		rcu_torture_onoff_init(void)
		{
		int ret;

		if (onoff_interval <= 0)
		return 0;
		onoff_task = kthread_run(rcu_torture_onoff, NULL, "rcu_torture_onoff");
		if (IS_ERR(onoff_task)) {
		ret = PTR_ERR(onoff_task);
		onoff_task = NULL;
		return PTR_ERR(onoff_task);
		return ret;
		}
		return 0;
		}