Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b70a67d authored by Joe Perches's avatar Joe Perches Committed by Takashi Iwai
Browse files

ALSA: hda_intel: ratelimit "spurious response" message 



dmesg here has a 100+ consecutive lines of:

[ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
[ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
[ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
...

Ratelimit the message to reduce the dmesg log noise.

Coalesce the format while at it.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ca2b0295

sound/pci/hda/hda_intel.c

+3 −3
Original line number Diff line number Diff line
@@ -914,14 +914,14 @@ static void azx_update_rirb(struct azx *chip) 
			chip->rirb.res[addr] = res;

			smp_wmb();

			chip->rirb.cmds[addr]--;

		} else

			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, "

				   "last cmd=%#08x\n",

		} else if (printk_ratelimit()) {

			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, last cmd=%#08x\n",

				   pci_name(chip->pci),

				   res, res_ex,

				   chip->last_cmd[addr]);

		}

	}

}



/* receive a response */

static unsigned int azx_rirb_get_response(struct hda_bus *bus,