Commit 3b4c5cbf authored Oct 30, 2013 by Sergei Shtylyov Committed by David S. Miller Nov 04, 2013

sh_eth: check platform data pointer



Check the platform data pointer before dereferencing it and error out of the
probe() method if it's NULL.

This has additional effect of preventing kernel oops with outdated platform data
containing zero PHY address instead (such as on SolutionEngine7710).

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6f9fed0b

drivers/net/ethernet/renesas/sh_eth.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -2663,6 +2663,12 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
		pm_runtime_enable(&pdev->dev);
		pm_runtime_resume(&pdev->dev);

		if (!pd) {
		dev_err(&pdev->dev, "no platform data\n");
		ret = -EINVAL;
		goto out_release;
		}

		/* get PHY ID */
		mdp->phy_id = pd->phy;
		mdp->phy_interface = pd->phy_interface;