Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3af70613 authored by Dan Carpenter's avatar Dan Carpenter Committed by J. Bruce Fields
Browse files

nfsd4: memory corruption in numeric_name_to_id() 



"id" is type is a uid_t (32 bits) but on 64 bit systems strict_strtoul()
modifies 64 bits of data.  We should use kstrtouint() instead.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 92769108

fs/nfsd/nfs4idmap.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -581,7 +581,7 @@ numeric_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namel 
	/* Just to make sure it's null-terminated: */

	/* Just to make sure it's null-terminated: */

	memcpy(buf, name, namelen);

	memcpy(buf, name, namelen);

	buf[namelen] = '\0';

	buf[namelen] = '\0';

	ret = strict_strtoul(name, 10, (unsigned long *)id);

	ret = kstrtouint(name, 10, id);

	return ret == 0;

	return ret == 0;

}

}