Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3992c8ed authored by David Ertman's avatar David Ertman Committed by Jeff Kirsher
Browse files

e1000e: Cleanup return values in ethtool 



Changing occurrences of returning 0 and 1 from bool functions to false and
true, respectively

Signed-off-by: default avatarDave Ertman <davidx.m.ertman@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent b8ce18cd

drivers/net/ethernet/intel/e1000e/ethtool.c

+4 −4
Original line number Diff line number Diff line
@@ -783,10 +783,10 @@ static bool reg_pattern_test(struct e1000_adapter *adapter, u64 *data, 
			      reg + (offset << 2), val,

			      (test[pat] & write & mask));

			*data = reg;

			return 1;

			return true;

		}

	}

	return 0;

	return false;

}



static bool reg_set_and_check(struct e1000_adapter *adapter, u64 *data,
@@ -799,9 +799,9 @@ static bool reg_set_and_check(struct e1000_adapter *adapter, u64 *data, 
		e_err("set/check test failed (reg 0x%05X): got 0x%08X expected 0x%08X\n",

		      reg, (val & mask), (write & mask));

		*data = reg;

		return 1;

		return true;

	}

	return 0;

	return false;

}



#define REG_PATTERN_TEST_ARRAY(reg, offset, mask, write)                       \

drivers/net/ethernet/intel/e1000e/netdev.c

+2 −2
Original line number Diff line number Diff line
@@ -5170,7 +5170,7 @@ static bool e1000_tx_csum(struct e1000_ring *tx_ring, struct sk_buff *skb) 
	__be16 protocol;



	if (skb->ip_summed != CHECKSUM_PARTIAL)

		return 0;

		return false;



	if (skb->protocol == cpu_to_be16(ETH_P_8021Q))

		protocol = vlan_eth_hdr(skb)->h_vlan_encapsulated_proto;
@@ -5215,7 +5215,7 @@ static bool e1000_tx_csum(struct e1000_ring *tx_ring, struct sk_buff *skb) 
		i = 0;

	tx_ring->next_to_use = i;



	return 1;

	return true;

}



static int e1000_tx_map(struct e1000_ring *tx_ring, struct sk_buff *skb,