Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 39667782 authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Linus Torvalds
Browse files

checkpatch: if should not continue a preceeding brace 



We should not be continuing a braced section with an if, for example:

	if (...) {
	} if (...) {
	}

Detect this and suggest adding a newline.

Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 63f17f89

scripts/checkpatch.pl

+5 −0
Original line number Diff line number Diff line
@@ -2108,6 +2108,11 @@ sub process { 
				ERROR("trailing statements should be on next line\n" . $herecurr);

			}

		}

# if should not continue a brace

		if ($line =~ /}\s*if\b/) {

			ERROR("trailing statements should be on next line\n" .

				$herecurr);

		}

# case and default should not have general statements after them

		if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&

		    $line !~ /\G(?: