Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3913fd5e authored by Dan Carpenter's avatar Dan Carpenter Committed by Grant Likely
Browse files

gpio: potential null dereference 



Smatch found a potential null dereference in gpio_setup_irq().  The
"pdesc" variable is allocated with idr_find() that can return NULL.  If
gpio_setup_irq() is called with 0 as gpio_flags and "pdesc" is null, it
would OOPs here.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
parent 01bf0b64

drivers/gpio/gpiolib.c

+2 −1
Original line number Diff line number Diff line
@@ -416,6 +416,7 @@ static int gpio_setup_irq(struct gpio_desc *desc, struct device *dev, 
	return 0;



free_sd:

	if (pdesc)

		sysfs_put(pdesc->value_sd);

free_id:

	idr_remove(&pdesc_idr, id);