Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38ada214 authored by Yong Zhang's avatar Yong Zhang Committed by Grant Likely
Browse files

spi: irq: Remove IRQF_DISABLED 



Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: default avatarYong Zhang <yong.zhang0@gmail.com>
Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
parent 1458d160

drivers/spi/spi-bfin5xx.c

+1 −1
Original line number Diff line number Diff line
@@ -1098,7 +1098,7 @@ static int bfin_spi_setup(struct spi_device *spi) 


	if (chip->pio_interrupt && !drv_data->irq_requested) {

		ret = request_irq(drv_data->spi_irq, bfin_spi_pio_irq_handler,

			IRQF_DISABLED, "BFIN_SPI", drv_data);

			0, "BFIN_SPI", drv_data);

		if (ret) {

			dev_err(&spi->dev, "Unable to register spi IRQ\n");

			goto error;

drivers/spi/spi-coldfire-qspi.c

+1 −1
Original line number Diff line number Diff line
@@ -487,7 +487,7 @@ static int __devinit mcfqspi_probe(struct platform_device *pdev) 
		goto fail2;

	}



	status = request_irq(mcfqspi->irq, mcfqspi_irq_handler, IRQF_DISABLED,

	status = request_irq(mcfqspi->irq, mcfqspi_irq_handler, 0,

			     pdev->name, mcfqspi);

	if (status) {

		dev_dbg(&pdev->dev, "request_irq failed\n");

drivers/spi/spi-ppc4xx.c

+1 −1
Original line number Diff line number Diff line
@@ -514,7 +514,7 @@ static int __init spi_ppc4xx_of_probe(struct platform_device *op) 
	/* Request IRQ */

	hw->irqnum = irq_of_parse_and_map(np, 0);

	ret = request_irq(hw->irqnum, spi_ppc4xx_int,

			  IRQF_DISABLED, "spi_ppc4xx_of", (void *)hw);

			  0, "spi_ppc4xx_of", (void *)hw);

	if (ret) {

		dev_err(dev, "unable to allocate interrupt\n");

		goto free_gpios;

drivers/spi/spi-sh-msiof.c

+1 −1
Original line number Diff line number Diff line
@@ -635,7 +635,7 @@ static int sh_msiof_spi_probe(struct platform_device *pdev) 
		goto err2;

	}



	ret = request_irq(i, sh_msiof_spi_irq, IRQF_DISABLED,

	ret = request_irq(i, sh_msiof_spi_irq, 0,

			  dev_name(&pdev->dev), p);

	if (ret) {

		dev_err(&pdev->dev, "unable to request irq\n");

drivers/spi/spi-sh.c

+1 −1
Original line number Diff line number Diff line
@@ -484,7 +484,7 @@ static int __devinit spi_sh_probe(struct platform_device *pdev) 
		goto error2;

	}



	ret = request_irq(irq, spi_sh_irq, IRQF_DISABLED, "spi_sh", ss);

	ret = request_irq(irq, spi_sh_irq, 0, "spi_sh", ss);

	if (ret < 0) {

		dev_err(&pdev->dev, "request_irq error\n");

		goto error3;