Commit 3886ff5f authored Jun 30, 2008 by Ben Dooks Committed by Pierre Ossman Jul 15, 2008

MMC: S3C24XX: Fix s3c2410_dma_request() return code check.



The driver should be checking for a negative error code from
s3c2410_dma_request(), not non-zero. Newer kernels now return
the DMA channel number that was allocated by the request.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>

parent 55d70f5a

drivers/mmc/host/s3cmci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1215,7 +1215,7 @@ static int __devinit s3cmci_probe(struct platform_device *pdev, int is2440)
		s3c2410_gpio_cfgpin(host->pdata->gpio_wprotect,
		S3C2410_GPIO_INPUT);

		if (s3c2410_dma_request(S3CMCI_DMA, &s3cmci_dma_client, NULL)) {
		if (s3c2410_dma_request(S3CMCI_DMA, &s3cmci_dma_client, NULL) < 0) {
		dev_err(&pdev->dev, "unable to get DMA channel.\n");
		ret = -EBUSY;
		goto probe_free_irq_cd;