Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 386f1c96 authored by Lendacky, Thomas's avatar Lendacky, Thomas Committed by David S. Miller
Browse files

amd-xgbe: Properly handle feature changes via ethtool 



The ndo_set_features callback function was improperly using an unsigned
int to save the current feature value for features such as NETIF_F_RXCSUM.
Since that feature is in the upper 32 bits of a 64 bit variable the
result was always 0 making it not possible to actually turn off the
hardware RX checksum support.  Change the unsigned int type to the
netdev_features_t type in order to properly capture the current value
and perform the proper operation.

Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 81f35ffd

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

+1 −1
Original line number Diff line number Diff line
@@ -1465,7 +1465,7 @@ static int xgbe_set_features(struct net_device *netdev, 
{

	struct xgbe_prv_data *pdata = netdev_priv(netdev);

	struct xgbe_hw_if *hw_if = &pdata->hw_if;

	unsigned int rxcsum, rxvlan, rxvlan_filter;

	netdev_features_t rxcsum, rxvlan, rxvlan_filter;



	rxcsum = pdata->netdev_features & NETIF_F_RXCSUM;

	rxvlan = pdata->netdev_features & NETIF_F_HW_VLAN_CTAG_RX;