Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3856e548 authored by Amos Kong's avatar Amos Kong Committed by Rusty Russell
Browse files

virtio-rng: fix stuck of hot-unplugging busy device 



When we try to hot-remove a busy virtio-rng device from QEMU monitor,
the device can't be hot-removed. Because virtio-rng driver hangs at
wait_for_completion_killable().

This patch exits the waiting by completing have_data completion before
unregistering, resets data_avail to avoid the hwrng core use wrong
buffer bytes.

Signed-off-by: default avatarAmos Kong <akong@redhat.com>
Reviewed-by: default avatarAmit Shah <amit.shah@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 7ec62d42

drivers/char/hw_random/virtio-rng.c

+2 −0
Original line number Diff line number Diff line
@@ -137,6 +137,8 @@ static void remove_common(struct virtio_device *vdev) 
{

	struct virtrng_info *vi = vdev->priv;



	vi->data_avail = 0;

	complete(&vi->have_data);

	vdev->config->reset(vdev);

	vi->busy = false;

	if (vi->hwrng_register_done)