Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3724dde9 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab
Browse files

[media] cx231xx: Replace memcpy with struct assignment 

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 5344fe6e

drivers/media/usb/cx231xx/cx231xx-cards.c

+1 −1
Original line number Diff line number Diff line
@@ -736,7 +736,7 @@ static void cx231xx_sleep_s5h1432(struct cx231xx *dev) 


static inline void cx231xx_set_model(struct cx231xx *dev)

{

	memcpy(&dev->board, &cx231xx_boards[dev->model], sizeof(dev->board));

	dev->board = cx231xx_boards[dev->model];

}



/* Since cx231xx_pre_card_setup() requires a proper dev->model,

drivers/media/usb/cx231xx/cx231xx-video.c

+1 −2
Original line number Diff line number Diff line
@@ -2627,8 +2627,7 @@ int cx231xx_register_analog_devices(struct cx231xx *dev) 
		     dev->name, video_device_node_name(dev->vdev));



	/* Initialize VBI template */

	memcpy(&cx231xx_vbi_template, &cx231xx_video_template,

	       sizeof(cx231xx_vbi_template));

	cx231xx_vbi_template = cx231xx_video_template;

	strcpy(cx231xx_vbi_template.name, "cx231xx-vbi");



	/* Allocate and fill vbi video_device struct */