Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36839287 authored by Guenter Roeck's avatar Guenter Roeck Committed by Guenter Roeck
Browse files

hwmon: (ltc4261) Convert to use devm_kzalloc 



Marginally less code and eliminate the possibility of memory leaks.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent dd285ad7

drivers/hwmon/ltc4261.c

+4 −11
Original line number Diff line number Diff line
@@ -235,11 +235,9 @@ static int ltc4261_probe(struct i2c_client *client, 
		return -ENODEV;

	}



	data = kzalloc(sizeof(*data), GFP_KERNEL);

	if (!data) {

		ret = -ENOMEM;

		goto out_kzalloc;

	}

	data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);

	if (!data)

		return -ENOMEM;



	i2c_set_clientdata(client, data);

	mutex_init(&data->update_lock);
@@ -250,7 +248,7 @@ static int ltc4261_probe(struct i2c_client *client, 
	/* Register sysfs hooks */

	ret = sysfs_create_group(&client->dev.kobj, &ltc4261_group);

	if (ret)

		goto out_sysfs_create_group;

		return ret;



	data->hwmon_dev = hwmon_device_register(&client->dev);

	if (IS_ERR(data->hwmon_dev)) {
@@ -262,9 +260,6 @@ static int ltc4261_probe(struct i2c_client *client, 


out_hwmon_device_register:

	sysfs_remove_group(&client->dev.kobj, &ltc4261_group);

out_sysfs_create_group:

	kfree(data);

out_kzalloc:

	return ret;

}
@@ -275,8 +270,6 @@ static int ltc4261_remove(struct i2c_client *client) 
	hwmon_device_unregister(data->hwmon_dev);

	sysfs_remove_group(&client->dev.kobj, &ltc4261_group);



	kfree(data);



	return 0;

}