Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3655d54a authored by Darren Jenkins's avatar Darren Jenkins Committed by Dave Airlie
Browse files

drm/radeon/radeon_fence.c: move a dereference below the NULL test 



If a NULL value is possible, the dereference should only occur after the
NULL test.

Coverity CID: 13334

Signed-off-by: default avatarDarren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent d8a7f792

drivers/gpu/drm/radeon/radeon_fence.c

+4 −5
Original line number Diff line number Diff line
@@ -140,16 +140,15 @@ int radeon_fence_create(struct radeon_device *rdev, struct radeon_fence **fence) 


bool radeon_fence_signaled(struct radeon_fence *fence)

{

	struct radeon_device *rdev = fence->rdev;

	unsigned long irq_flags;

	bool signaled = false;



	if (rdev->gpu_lockup) {

	if (!fence)

		return true;

	}

	if (fence == NULL) {



	if (fence->rdev->gpu_lockup)

		return true;

	}



	write_lock_irqsave(&fence->rdev->fence_drv.lock, irq_flags);

	signaled = fence->signaled;

	/* if we are shuting down report all fence as signaled */