Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 360fa588 authored by Ben Dooks's avatar Ben Dooks Committed by Linus Torvalds
Browse files

s3c2410fb: fix clockrate calculation 



In the final part of the calculation for the tft display clockrate we
divide the output pf s3c2410fb_calc_pixclk() by 2 which leaves us with a
rounding error if the result is odd.

Change to using DIV_ROUND_UP() to ensure that we always choose a higher
divisor and thus a lower frequency.

Signed-off-by: default avatarBen Dooks <ben@simtec.co.uk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9a4a83d2

drivers/video/s3c2410fb.c

+3 −1
Original line number Diff line number Diff line
@@ -369,7 +369,9 @@ static void s3c2410fb_activate_var(struct fb_info *info) 
	void __iomem *regs = fbi->io;

	int type = fbi->regs.lcdcon1 & S3C2410_LCDCON1_TFT;

	struct fb_var_screeninfo *var = &info->var;

	int clkdiv = s3c2410fb_calc_pixclk(fbi, var->pixclock) / 2;

	int clkdiv;



	clkdiv = DIV_ROUND_UP(s3c2410fb_calc_pixclk(fbi, var->pixclock), 2);



	dprintk("%s: var->xres  = %d\n", __func__, var->xres);

	dprintk("%s: var->yres  = %d\n", __func__, var->yres);