Commit 359570ad authored Dec 14, 2012 by Axel Lin Committed by Jonathan Cameron Dec 27, 2012

iio: dac: ad5686: Don't set error code to voltage_uv



regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent 8434e785

drivers/iio/dac/ad5686.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -332,7 +332,11 @@ static int __devinit ad5686_probe(struct spi_device *spi)
		if (ret)
		goto error_put_reg;

		voltage_uv = regulator_get_voltage(st->reg);
		ret = regulator_get_voltage(st->reg);
		if (ret < 0)
		goto error_disable_reg;

		voltage_uv = ret;
		}

		st->chip_info =