Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34d28e0e authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

kaweth: fix firmware download 



commit 60bcabd080f53561efa9288be45c128feda1a8bb upstream.

This fixes the oops discovered by the Umap2 project and Alan Stern.
The intf member needs to be set before the firmware is downloaded.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarAmit Pundir <amit.pundir@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c5c94ca0

drivers/net/usb/kaweth.c

+1 −2
Original line number Diff line number Diff line
@@ -1029,6 +1029,7 @@ static int kaweth_probe( 
	kaweth = netdev_priv(netdev);

	kaweth->dev = udev;

	kaweth->net = netdev;

	kaweth->intf = intf;



	spin_lock_init(&kaweth->device_lock);

	init_waitqueue_head(&kaweth->term_wait);
@@ -1139,8 +1140,6 @@ err_fw: 


	dev_dbg(dev, "Initializing net device.\n");



	kaweth->intf = intf;



	kaweth->tx_urb = usb_alloc_urb(0, GFP_KERNEL);

	if (!kaweth->tx_urb)

		goto err_free_netdev;