Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34a1b723 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

kthreads: kill CLONE_KERNEL, change kernel_thread(kernel_init) to avoid CLONE_SIGHAND 



1. Remove CLONE_KERNEL, it has no users and it is dangerous.

   The (old) comment says "List of flags we want to share for kernel
   threads" but this is not true, we do not want to share ->sighand by
   default. This flag can only be used if the caller is sure that both
   parent/child will never play with signals (say, allow_signal/etc).

2. Change rest_init() to clone kernel_init() without CLONE_SIGHAND.

   In this case CLONE_SIGHAND does not really hurt, and it looks like
   optimization because copy_sighand() can avoid kmem_cache_alloc().

   But in fact this only adds the minor pessimization. kernel_init()
   is going to exec the init process, and de_thread() will need to
   unshare ->sighand and do kmem_cache_alloc(sighand_cachep) anyway,
   but it needs to do more work and take tasklist_lock and siglock.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarPeter Zijlstra <peterz@infradead.org>
Acked-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7b0b73d7

include/linux/sched.h

+0 −6
Original line number Diff line number Diff line
@@ -136,12 +136,6 @@ struct filename; 
#define VMACACHE_SIZE (1U << VMACACHE_BITS)

#define VMACACHE_MASK (VMACACHE_SIZE - 1)



/*

 * List of flags we want to share for kernel threads,

 * if only because they are not used by them anyway.

 */

#define CLONE_KERNEL	(CLONE_FS | CLONE_FILES | CLONE_SIGHAND)



/*

 * These are the constant used to fake the fixed-point load-average

 * counting. Some notes:

init/main.c

+1 −1
Original line number Diff line number Diff line
@@ -380,7 +380,7 @@ static noinline void __init_refok rest_init(void) 
	 * the init task will end up wanting to create kthreads, which, if

	 * we schedule it before we create kthreadd, will OOPS.

	 */

	kernel_thread(kernel_init, NULL, CLONE_FS | CLONE_SIGHAND);

	kernel_thread(kernel_init, NULL, CLONE_FS);

	numa_default_policy();

	pid = kernel_thread(kthreadd, NULL, CLONE_FS | CLONE_FILES);

	rcu_read_lock();