Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 33a94741 authored by Dhaval Patel's avatar Dhaval Patel
Browse files

msm: mdss: fix solid fill programming on pipe 



Format on pipe is changed to solid fill when it is
un-staged from mixer and put in cleanup list. This is
not required because HW is not going to pick up this pipe
when it is not present on any stage. This change removes
the unnecessary programming during cleanup and updates the
sw pixel extension configuration for solid fill pipe.

Change-Id: Idabd264dc9a3e93ef94e347e7f48fd6f88bd987b
Signed-off-by: default avatarDhaval Patel <pdhaval@codeaurora.org>
parent d9642cc2

drivers/video/msm/mdss/mdss_mdp_overlay.c

+0 −1
Original line number Diff line number Diff line
@@ -1898,7 +1898,6 @@ int mdss_mdp_overlay_kickoff(struct msm_fb_data_type *mfd, 
	 * to ensure no fetches are happening after dettach or reattach.

	 */

	list_for_each_entry_safe(pipe, tmp, &mdp5_data->pipes_cleanup, list) {

		mdss_mdp_pipe_queue_data(pipe, NULL);

		mdss_mdp_mixer_pipe_unstage(pipe, pipe->mixer_left);

		mdss_mdp_mixer_pipe_unstage(pipe, pipe->mixer_right);

		list_move(&pipe->list, &destroy_pipes);

drivers/video/msm/mdss/mdss_mdp_pipe.c

+4 −2
Original line number Diff line number Diff line
@@ -1986,7 +1986,7 @@ static int mdss_mdp_src_addr_setup(struct mdss_mdp_pipe *pipe, 
static int mdss_mdp_pipe_solidfill_setup(struct mdss_mdp_pipe *pipe)

{

	int ret;

	u32 secure, format, unpack;

	u32 secure, format, unpack, opmode = 0;



	pr_debug("solid fill setup on pnum=%d\n", pipe->num);
@@ -2007,7 +2007,9 @@ static int mdss_mdp_pipe_solidfill_setup(struct mdss_mdp_pipe *pipe) 
		pipe->bg_color);

	mdss_mdp_pipe_write(pipe, MDSS_MDP_REG_SSPP_SRC_UNPACK_PATTERN, unpack);

	mdss_mdp_pipe_write(pipe, MDSS_MDP_REG_SSPP_SRC_ADDR_SW_STATUS, secure);

	mdss_mdp_pipe_write(pipe, MDSS_MDP_REG_SSPP_SRC_OP_MODE, 0);

	if (pipe->scale.enable_pxl_ext)

		opmode |= (1 << 31);

	mdss_mdp_pipe_write(pipe, MDSS_MDP_REG_SSPP_SRC_OP_MODE, opmode);



	if (pipe->type != MDSS_MDP_PIPE_TYPE_DMA) {

		mdss_mdp_pipe_write(pipe, MDSS_MDP_REG_SCALE_CONFIG, 0);