Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 327531ba authored by Axel Lin's avatar Axel Lin Committed by Liam Girdwood
Browse files

regulator: tps6586x-regulator - fix value range checking for val 



val is used as array index of ri->voltages.
Thus the valid value range should be 0 .. ri->desc.n_voltages - 1.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent c356cbc2

drivers/regulator/tps6586x-regulator.c

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static int tps6586x_ldo_get_voltage(struct regulator_dev *rdev) 
	mask = ((1 << ri->volt_nbits) - 1) << ri->volt_shift;

	val = (val & mask) >> ri->volt_shift;



	if (val > ri->desc.n_voltages)

	if (val >= ri->desc.n_voltages)

		BUG();



	return ri->voltages[val] * 1000;