Commit 3271a4fc authored Dec 20, 2012 by Axel Lin Committed by Mark Brown Dec 24, 2012

ASoC: cs42l52: Catch no-match case in cs42l52_get_clk



In the case of no-match, return -EINVAL instead of 0.

Since we assign i to ret in the for loop, ret always less than
ARRAY_SIZE(clk_map_table). Thus remove the boundary checking for ret.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent a49f0d1e

sound/soc/codecs/cs42l52.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -737,7 +737,7 @@ static const struct cs42l52_clk_para clk_map_table[] = {

		static int cs42l52_get_clk(int mclk, int rate)
		{
		int i, ret = 0;
		int i, ret = -EINVAL;
		u_int mclk1, mclk2 = 0;

		for (i = 0; i < ARRAY_SIZE(clk_map_table); i++) {
		@@ -749,8 +749,6 @@ static int cs42l52_get_clk(int mclk, int rate)
		}
		}
		}
		if (ret > ARRAY_SIZE(clk_map_table))
		return -EINVAL;
		return ret;
		}