Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3256a055 authored by Ryusuke Konishi's avatar Ryusuke Konishi
Browse files

nilfs2: fix potential leak of dirty data on umount 



This fixes incorrect usage of nilfs_segctor_confirm() test function in
nilfs_segctor_destroy(); nilfs_segctor_confirm() returns zero if the
filesystem is not clean, so its use in nilfs_segctor_destroy() needs
inversion.

Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
parent abe94c75

fs/nilfs2/segment.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -2829,7 +2829,7 @@ static void nilfs_segctor_destroy(struct nilfs_sc_info *sci) 
		|| sci->sc_seq_request != sci->sc_seq_done);

		|| sci->sc_seq_request != sci->sc_seq_done);

	spin_unlock(&sci->sc_state_lock);

	spin_unlock(&sci->sc_state_lock);





	if (flag || nilfs_segctor_confirm(sci))

	if (flag || !nilfs_segctor_confirm(sci))

		nilfs_segctor_write_out(sci);

		nilfs_segctor_write_out(sci);





	WARN_ON(!list_empty(&sci->sc_copied_buffers));

	WARN_ON(!list_empty(&sci->sc_copied_buffers));