Commit 3233cdbd authored Feb 16, 2011 by Tejun Heo

workqueue: make sure MAYDAY_INITIAL_TIMEOUT is at least 2 jiffies long



MAYDAY_INITIAL_TIMEOUT is defined as HZ / 100 and depending on
configuration may end up 0 or 1.  Even when it's 1, depending on when
the mayday timer is added in the current jiffy interval, it may expire
way before a jiffy has passed.

Make sure MAYDAY_INITIAL_TIMEOUT is at least two to guarantee that at
least a full jiffy has passed before calling rescuers.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Ray Jui <rjui@broadcom.com>
Cc: stable@kernel.org

parent 58a69cb4

kernel/workqueue.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -79,7 +79,9 @@ enum {
		MAX_IDLE_WORKERS_RATIO = 4, /* 1/4 of busy can be idle */
		IDLE_WORKER_TIMEOUT = 300 * HZ, /* keep idle ones for 5 mins */

		MAYDAY_INITIAL_TIMEOUT = HZ / 100, /* call for help after 10ms */
		MAYDAY_INITIAL_TIMEOUT = HZ / 100 >= 2 ? HZ / 100 : 2,
		/* call for help after 10ms
		(min two ticks) */
		MAYDAY_INTERVAL = HZ / 10, /* and then every 100ms */
		CREATE_COOLDOWN = HZ, /* time to breath after fail */
		TRUSTEE_COOLDOWN = HZ / 10, /* for trustee draining */