Commit 318b0e84 authored Jun 17, 2018 by Stefan Agner Committed by Greg Kroah-Hartman Aug 28, 2018

net: hamradio: use eth_broadcast_addr



[ Upstream commit 4e8439aa34802deab11cee68b0ecb18f887fb153 ]

The array bpq_eth_addr is only used to get the size of an
address, whereas the bcast_addr is used to set the broadcast
address. This leads to a warning when using clang:
drivers/net/hamradio/bpqether.c:94:13: warning: variable 'bpq_eth_addr' is not
      needed and will not be emitted [-Wunneeded-internal-declaration]
static char bpq_eth_addr[6];
            ^

Remove both variables and use the common eth_broadcast_addr
to set the broadcast address.

Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2416eb02

drivers/net/hamradio/bpqether.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -90,10 +90,6 @@
		static const char banner[] __initconst = KERN_INFO \
		"AX.25: bpqether driver version 004\n";

		static char bcast_addr[6]={0xFF,0xFF,0xFF,0xFF,0xFF,0xFF};

		static char bpq_eth_addr[6];

		static int bpq_rcv(struct sk_buff , struct net_device , struct packet_type , struct net_device );
		static int bpq_device_event(struct notifier_block , unsigned long, void );

		@@ -512,8 +508,8 @@ static int bpq_new_device(struct net_device *edev)
		bpq->ethdev = edev;
		bpq->axdev = ndev;

		memcpy(bpq->dest_addr, bcast_addr, sizeof(bpq_eth_addr));
		memcpy(bpq->acpt_addr, bcast_addr, sizeof(bpq_eth_addr));
		eth_broadcast_addr(bpq->dest_addr);
		eth_broadcast_addr(bpq->acpt_addr);

		err = register_netdevice(ndev);
		if (err)