Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 315e8f75 authored by Kulikov Vasiliy's avatar Kulikov Vasiliy Committed by Takashi Iwai
Browse files

ALSA: asihpi: fix sign bug 



bytes_per_sec is unsigned, so if snd_pcm_format_width() return error we
would not see it.

Signed-off-by: default avatarKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1d8c1100

sound/pci/asihpi/asihpi.c

+4 −2
Original line number Diff line number Diff line
@@ -460,6 +460,7 @@ static int snd_card_asihpi_pcm_hw_params(struct snd_pcm_substream *substream, 
	struct snd_card_asihpi *card = snd_pcm_substream_chip(substream);

	int err;

	u16 format;

	int width;

	unsigned int bytes_per_sec;



	print_hwparams(params);
@@ -512,9 +513,10 @@ static int snd_card_asihpi_pcm_hw_params(struct snd_pcm_substream *substream, 
				dpcm->hpi_buffer_attached);

	}

	bytes_per_sec = params_rate(params) * params_channels(params);

	bytes_per_sec *= snd_pcm_format_width(params_format(params));

	width = snd_pcm_format_width(params_format(params));

	bytes_per_sec *= width;

	bytes_per_sec /= 8;

	if (bytes_per_sec <= 0)

	if (width < 0 || bytes_per_sec == 0)

		return -EINVAL;



	dpcm->bytes_per_sec = bytes_per_sec;