Commit 30883ea8 authored Jan 09, 2010 by Uwe Kleine-König Committed by Mauro Carvalho Chehab Jan 17, 2010

V4L/DVB mx1_camera: don't check platform_get_irq's return value against zero



platform_get_irq returns -ENXIO on failure, so !irq was probably
always true.  Better use (int)irq <= 0.  Note that a return value of
zero is still handled as error even though this could mean irq0.

This is a followup to 305b3228 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.

Cc: David Vrabel <dvrabel@arcom.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Antonio Ospite <ospite@studenti.unina.it>
Cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
Cc: linux-media@vger.kernel.org
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 3f76cf8c

drivers/media/video/mx1_camera.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -718,7 +718,7 @@ static int __init mx1_camera_probe(struct platform_device *pdev)

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		irq = platform_get_irq(pdev, 0);
		if (!res \|\| !irq) {
		if (!res \|\| (int)irq <= 0) {
		err = -ENODEV;
		goto exit;
		}